:: commit c541733dc81a81da4282fc1196e3f91d37bc9aa0

Mintsuki <mintsuki@protonmail.com> — 2026-02-07 08:29

parents: 6528870994

lib/gterm: Fix off-by-one OOB read in tiled background rendering

diff --git a/common/lib/gterm.c b/common/lib/gterm.c
index 099e9c3b..3b8fe47c 100644
--- a/common/lib/gterm.c
+++ b/common/lib/gterm.c
@@ -367,7 +367,7 @@ __attribute__((always_inline)) static inline void genloop(struct fb_info *fb, si
                 uint32_t img_pixel = *(uint32_t*)(img + image_x * colsize + off);
                 uint32_t i = blend(fb, x, y, img_pixel);
                 bg_canvas[canvas_off + x] = i;
-                if (image_x++ == img_width) image_x = 0; // image_x = x % img_width, but modulo is too expensive
+                if (++image_x == img_width) image_x = 0; // image_x = x % img_width, but modulo is too expensive
             }
         }
         break;
tab: 248 wrap: offon