:: commit 4820efdf2e5caa56977fc53636f4a3fc90942977

Mintsuki <mintsuki@protonmail.com> — 2025-12-24 22:13

parents: 6598649c02

fs/file: Fix minor memory leaks on fopen() failure

diff --git a/common/fs/file.s2.c b/common/fs/file.s2.c
index 80aa2ff7..4db44f4b 100644
--- a/common/fs/file.s2.c
+++ b/common/fs/file.s2.c
@@ -45,8 +45,9 @@ struct file_handle *fopen(struct volume *part, const char *filename) {
 
     if (part->pxe) {
         if ((ret = tftp_open(part, "", filename)) == NULL) {
-            return NULL;
+            goto err;
         }
+        pmm_free(filename_new, filename_new_len);
         return ret;
     }
 
@@ -57,6 +58,8 @@ struct file_handle *fopen(struct volume *part, const char *filename) {
         goto success;
     }
 
+err:
+    pmm_free(filename_new, filename_new_len);
     return NULL;
 
 success:
tab: 248 wrap: offon