:: commit d6a9032cd9a3bcb81b8a70d0a7b159fc29fa54e4

Mintsuki <mintsuki@protonmail.com> — 2026-03-06 18:43

parents: 138a6fb8c7

lib/gterm: Check parse_resolution return value for TERM_FONT_SIZE to avoid uninitialized use

diff --git a/common/lib/gterm.c b/common/lib/gterm.c
index 385dd012..d44b64ad 100644
--- a/common/lib/gterm.c
+++ b/common/lib/gterm.c
@@ -703,7 +703,10 @@ bool gterm_init(struct fb_info **_fbs, size_t *_fbs_count,
 
     char *menu_font_size = config_get_value(config, 0, "TERM_FONT_SIZE");
     if (menu_font_size != NULL) {
-        parse_resolution(&tmp_font_width, &tmp_font_height, NULL, menu_font_size);
+        if (!parse_resolution(&tmp_font_width, &tmp_font_height, NULL, menu_font_size)) {
+            print("Could not parse TERM_FONT_SIZE. Using default font.\n");
+            goto no_load_font;
+        }
 
         if (tmp_font_width != 8) {
             print("Font width must be 8, got %u. Using default font.\n", tmp_font_width);
tab: 248 wrap: offon